fix(svelte5): do not deeply proxify passed-in props #456
+221
−173
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces our
$statewrapper around the passed inpropswith a custom$state.raw+Proxysolution to create a "shallow state" aroundpropsThis shallow state allows
rerenderto continue to function while avoiding the weirdness of implicitly turning everything insidepropsinto aProxy, which is not how Svelte operates at runtime.Long term, we should probably remove
rerenderand any internal reactive state entirely. If a user needs to rerender, they can pass their own$statein themselves. Happily, this new implementation already supports that, so I can explore a deprecation notice and update to the docs in a follow-upFixes #455